-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added link to restrictions badge #1456
Conversation
Yeah, we should have the same color. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, just a small change.
spec/features/catalog_view_spec.rb
Outdated
it "lets someone click on the access restrictions badge", js: true do | ||
visit "/catalog/AC136_c2889" | ||
click_on "Restrictions may apply. See Access Note." | ||
expect(page).to have_content("Access & Use") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is always there, https://findingaids.princeton.edu/catalog/MC247. Is there content we can check that is only there after you click the link, and not before?
@Seanwarren77 Looking good. There's some code style problems (lint is failing) - you can fix them by running Oops I'm wrong - this problem is what @hackartisan fixed. Just rebase and you should be good - you can do that via:
|
b1d653f
to
d64af50
Compare
Now the link color is the same @tpendragon I also updated the test.
Ref #1368