Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link to restrictions badge #1456

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Added link to restrictions badge #1456

merged 5 commits into from
Nov 19, 2024

Conversation

Seanwarren77
Copy link
Contributor

@Seanwarren77 Seanwarren77 commented Nov 15, 2024

Screenshot 2024-11-19 at 9 42 11 AM

Now the link color is the same @tpendragon I also updated the test.

Ref #1368

@tpendragon
Copy link
Contributor

The color changed inside of the badge, do I need to change the color back to original color?

Yeah, we should have the same color.

Copy link
Contributor

@tpendragon tpendragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, just a small change.

it "lets someone click on the access restrictions badge", js: true do
visit "/catalog/AC136_c2889"
click_on "Restrictions may apply. See Access Note."
expect(page).to have_content("Access & Use")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is always there, https://findingaids.princeton.edu/catalog/MC247. Is there content we can check that is only there after you click the link, and not before?

@tpendragon
Copy link
Contributor

tpendragon commented Nov 19, 2024

@Seanwarren77 Looking good. There's some code style problems (lint is failing) - you can fix them by running bundle exec rubocop -a and committing the changes that makes.

Oops I'm wrong - this problem is what @hackartisan fixed. Just rebase and you should be good - you can do that via:

git switch main
git pull
git switch i1368_clickable_badge
git rebase main
git push -f

@tpendragon tpendragon merged commit 77c9316 into main Nov 19, 2024
4 checks passed
@tpendragon tpendragon deleted the i1368_clickable_badge branch November 19, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants