Python 3.12 and assorted fixes #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix SSLV3_ALERT_HANDSHAKE_FAILURE for some imap servers. They use old, less secure ciphers that are disabled for Python 3.10. See <https://stackoverflow.com/a/71007463>.
bryango
force-pushed
the
master
branch
22 times, most recently
from
159935a to
23b689f
Compare
This fix was originally provided by Lalufu in #fedora-devel, and posted on the issue tracker by @knurd.
This prevents SyntaxWarning: invalid escape sequence
bryango
changed the title
|
Any hopes to get this and other fixes included in a new release? |
It seems that mailnag is unmaintained. I will keep this PR open here, tracking my own minimal, personal fork. There are other forks with this patch merged while incorporating other improvements at the same time. You can track one of those forks (but with due caution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the app work for python 3.12. It incorporates the fix from #245 (comment). Closes:
Some other improvements:
Fix SSLV3_ALERT_HANDSHAKE_FAILURE for some imap servers
Connections to some imap servers (e.g. imap.pku.edu.cn) fail after upgrading to python 3.10. This is because they use old, less secure ciphers that are disabled for Python 3.10. In order to connect to those servers, we have to allow more ssl ciphers in imaplib2 for Python 3.10. See:
Also,