-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial Israel sources #476
base: main
Are you sure you want to change the base?
Conversation
The second one passes locally with the following change and #477:
|
Will try your configuration but it seems that Transitland was last updated 5 months ago, not so up-to-date. |
f9b32b5
to
7d9146a
Compare
7d9146a
to
2c20e0a
Compare
Still not sure why Israel-MOT is closing the connection so I skipped it for now |
"url": "https://gtfs.mot.gov.il/gtfsfiles/israel-public-transportation.zip", | ||
"http-options": { | ||
"headers": { | ||
"user-agent": "Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the HTTP RFCs state that the header field names should be case-insensitive, is this always true in practice? I think I've mostly seen "User-Agent" being used.
Maybe it could be worth trying to changing to that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to make https://github.com/public-transport/transitous/blob/main/src/fetch.py#L60 case-insensitive as well then.
I've sent a message to Busofash regarding their error in the GTFS file.