handle next-day legs on overnight journeys #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
force-pushed
the
issue-301-overnight-travel
branch
from
0cb5f94 to
46615a3
Compare
derhuerst
changed the title
derhuerst
force-pushed
the
issue-301-overnight-travel
branch
from
46615a3 to
0d2dc8f
Compare
|
It's been a while since I looked at this. Do you know if there is anything missing here? 🤔 |
|
Me too 😅 I'm not familiar with the library, but since the tests we wrote are now green, I guess that this can be merged? |
…y within the next day ✅ Co-Authored-By: Jannis R <[email protected]>
follow-up of a2870f6 related: public-transport#301
follow-up of a2870f6 follow-up of 6e6285c fixes public-transport#301
derhuerst
force-pushed
the
issue-301-overnight-travel
branch
from
0d2dc8f to
26c56f8
Compare
|
Do you want to be mentioned as a contributor in |
|
@derhuerst Thank you very much for the offer 😊! You can use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #301 (currently just reproducing it). I'm not yet sure how to fix it and will need some time to figure it out. Feel free to take over.