Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move offline provider into a separate module #283

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Move offline provider into a separate module #283

merged 1 commit into from
Nov 20, 2024

Conversation

x-hgg-x
Copy link
Contributor

@x-hgg-x x-hgg-x commented Nov 19, 2024

Part of #274.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 19, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #283 will improve performances by 3.85%

Comparing x-hgg-x:move-provider (584cad5) with dev (8a29d57)

Summary

⚡ 1 improvements
✅ 5 untouched benchmarks

Benchmarks breakdown

Benchmark dev x-hgg-x:move-provider Change
⚡ large_case_u16_NumberVersion.ron 21 ms 20.2 ms +3.85%

@konstin
Copy link
Member

konstin commented Nov 19, 2024

There are no code (logic) changes here, right? Cause that means that our benchmarks are noisy :/

@x-hgg-x
Copy link
Contributor Author

x-hgg-x commented Nov 19, 2024 •
edited
Loading

Iterators in choose_version and prioritize were no longer inlined after moving the code. Adding #[inline] fixed this.

@konstin konstin requested a review from Eh2406 November 19, 2024 22:09
Eh2406
Eh2406 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@Eh2406 Eh2406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Leaving open if @konstin has thoughts.

@konstin konstin added this pull request to the merge queue Nov 20, 2024
Merged via the queue into pubgrub-rs:dev with commit 4bde6d6 Nov 20, 2024
6 checks passed
@x-hgg-x x-hgg-x deleted the move-provider branch November 20, 2024 08:31
@x-hgg-x x-hgg-x mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstin konstin konstin approved these changes

@Eh2406 Eh2406 Eh2406 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@x-hgg-x @konstin @Eh2406