Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IntoIter on Ranges #276

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Add IntoIter on Ranges #276

merged 2 commits into from
Nov 12, 2024

Conversation

konstin
Copy link
Member

@konstin konstin commented Nov 8, 2024

To modify a version ranges and consume them with a construction method from #273, we want to allow not cloning the versions. This is supported through .into_iter().

@Eh2406
Copy link
Member

Eh2406 commented Nov 8, 2024

Do we also want to implement ExactSizeIterator and DoubleEndedIterator and FusedIterator on RangesIter?

@konstin
Copy link
Member Author

konstin commented Nov 10, 2024

Good idea, added ExactSizeIterator and DoubleEndedIterator, FusedIterator seems to already come from .fuse() though?

Copy link
Member

@Eh2406 Eh2406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Eh2406 Eh2406 enabled auto-merge November 11, 2024 17:43
@konstin konstin force-pushed the konsti/dev/into-iter branch from 5181c98 to d70a7d8 Compare November 12, 2024 13:09
@Eh2406 Eh2406 added this pull request to the merge queue Nov 12, 2024
Merged via the queue into dev with commit 2a37e13 Nov 12, 2024
5 checks passed
@Eh2406 Eh2406 deleted the konsti/dev/into-iter branch November 12, 2024 13:12
@konstin konstin added the Ranges label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants