perf: remove more redundant scanning #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing the stronger version of pubgrub-rs#175 because it turns out to be important to cargo crates.
|
Nice one! Is it not too penalizing for the other cases? |
mpizenberg
approved these changes
Aug 22, 2024
|
2% regression for elm 3% improvement from "large case", so basically all within the noise. |
|
I've rebased uv onto the latest commits and the are no changes in our benchmarks.
|
|
That makes perfect sense. This only really makes a difference in certain "pathological" cases. They just happened to be so slow that they are a large percentage of the benchmark suite I've chosen. But I'm glad it didn't regress your use cases. |
maciektr
pushed a commit
to software-mansion-labs/pubgrub
that referenced
this pull request
Nov 4, 2024
Doing the stronger version of pubgrub-rs#175 because it turns out to be important to cargo crates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing the stronger version of #175 because it turns out to be important to cargo crates.
While investigating Eh2406/pubgrub-crates-benchmark#6 I took a shot in the dark and thought it might have to do with this optimization. Indeed this one change brings the time to analyze the Solana crates down from 127.25min to 90.85min a 28% improvement.