Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Cargo.lock #195

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

konstin
Copy link
Member

@konstin konstin commented Mar 22, 2024

See https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html. This ensure we all have the same versions when developing pubgrub.

Are you interested in adding a dependabot for regular dependency updates?

@Eh2406
Copy link
Member

Eh2406 commented Mar 22, 2024

Are you interested in adding a dependabot for regular dependency updates?

Yes! I have not made time to figure out what's involved in setting up dependabot, help would deeply be appreciated. Do you want to do it in the same PR or rapid follow-up?

@konstin
Copy link
Member Author

konstin commented Mar 22, 2024

I'd split that into a separate PR

@konstin konstin force-pushed the konsti/dev/gitignored-cargo-lock branch 2 times, most recently from a517e67 to 5d11ed0 Compare March 22, 2024 15:39
Copy link
Member

@Eh2406 Eh2406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Eh2406 Eh2406 added this pull request to the merge queue Mar 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 22, 2024
@Eh2406 Eh2406 added this pull request to the merge queue Mar 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 22, 2024
See https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html

Are you interested in adding a dependabot for regular dependency updates?
@konstin konstin force-pushed the konsti/dev/gitignored-cargo-lock branch from 5d11ed0 to 7924fc8 Compare March 22, 2024 18:26
@konstin konstin added this pull request to the merge queue Mar 22, 2024
Merged via the queue into pubgrub-rs:dev with commit 4d895a1 Mar 22, 2024
5 checks passed
@konstin konstin deleted the konsti/dev/gitignored-cargo-lock branch March 22, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants