Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update priority queue #194

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

konstin
Copy link
Member

@konstin konstin commented Mar 22, 2024

I've been looking at duplicate dependencies in our tree and priority-queue 1 was pulling in old versions of indexmap and hashbrown, so i've updated all dependencies.

@@ -21,18 +21,18 @@ include = ["Cargo.toml", "LICENSE", "README.md", "src/**", "tests/**", "examples

[dependencies]
indexmap = "2.0.2"
priority-queue = "1.1.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thiserror = "1.0"
rustc-hash = "1.1.0"
serde = { version = "1.0", features = ["derive"], optional = true }
log = "0.4.14" # for debug logs in tests

[dev-dependencies]
proptest = "0.10.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thiserror = "1.0"
rustc-hash = "1.1.0"
serde = { version = "1.0", features = ["derive"], optional = true }
log = "0.4.14" # for debug logs in tests

[dev-dependencies]
proptest = "0.10.1"
ron = "0.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change log at https://github.com/ron-rs/ron/blob/master/CHANGELOG.md#060---2020-05-21 which all seems reasonable. Although we also could use a bug fix from prerelease of 0.9, but I have a separate PR for that.

varisat = "0.2.2"
criterion = "0.5"
env_logger = "0.9.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change log at https://github.com/rust-cli/env_logger/blob/main/CHANGELOG.md#090----2022-07-14 which I don't entirely understand but seemed reasonable.

@Eh2406 Eh2406 added this pull request to the merge queue Mar 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 22, 2024
@Eh2406
Copy link
Member

Eh2406 commented Mar 22, 2024

The commit message needs to follow conventional commits in order to successfully merge.

@konstin konstin force-pushed the konsti/dev/priority-queue-2 branch from 05d8bc9 to 2f8baa0 Compare March 22, 2024 16:07
@konstin
Copy link
Member Author

konstin commented Mar 22, 2024

Sorry, fixed

@Eh2406 Eh2406 added this pull request to the merge queue Mar 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 22, 2024
@konstin konstin added this pull request to the merge queue Mar 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 22, 2024
I've been looking at duplicate dependencies in our tree and priority-queue 1 was pulling in old versions of indexmap and hashbrown, so i've updated all dependencies.
@konstin konstin force-pushed the konsti/dev/priority-queue-2 branch from 2f8baa0 to 0c1f5d3 Compare March 22, 2024 18:24
@konstin
Copy link
Member Author

konstin commented Mar 22, 2024

Is there a reason there is no "chore" label for commits?

@konstin konstin added this pull request to the merge queue Mar 22, 2024
Merged via the queue into pubgrub-rs:dev with commit 94276e9 Mar 22, 2024
5 checks passed
@konstin konstin deleted the konsti/dev/priority-queue-2 branch March 22, 2024 18:27
@Eh2406
Copy link
Member

Eh2406 commented Mar 22, 2024

Not a good one that I understand. If you would like to add it to the CI go ahead and do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants