feat: ensure successful round-trip of RON #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eh2406
force-pushed
the
jf/Ron-Round-trip
branch
from
7308943 to
d551d77
Compare
mpizenberg
reviewed
Apr 4, 2024
src/range.rs
Outdated
| @@ -863,6 +863,13 @@ pub mod tests { | |||
| proptest! { | |||
|
|
|||
| // Testing negate ---------------------------------- | |||
There was a problem hiding this comment.
This "Testing negate" comment section should probably move after the serde round trip test.
Eh2406
force-pushed
the
jf/Ron-Round-trip
branch
from
78711fb to
0b09875
Compare
konstin
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc ron-rs/ron#530
When using the new format our benchmark files could not be read. Apparently this is going to be fixed in the next version of the RON dep. For now use the prerelease version.