Add Range::as_singleton
#186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
force-pushed
the
konsti/as-singleton
branch
from
b4c62c0 to
e219a80
Compare
Eh2406
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
I have wanted this from time to time! Seems like a sensible thing to merge.
The commit name will need to match conventional commits (or there will need to be more than one commit and the PR name matches conventional commits) for CI to merge. When that's taking care of +1.
src/range.rs
Outdated
| } else { | ||
| None | ||
| } | ||
| }^ |
konstin
force-pushed
the
konsti/as-singleton
branch
from
e219a80 to
587f547
Compare
I'll fixup the PRs |
Co-authored-by: Zanie Blue <[email protected]> Co-authored-by: Andrew Gallant <[email protected]> We use this method for better error messages: https://github.com/astral-sh/uv/blob/8d721830db8ad75b8b7ef38edc0e346696c52e3d/crates/uv-resolver/src/pubgrub/report.rs#L92-L96 https://github.com/astral-sh/uv/blob/8d721830db8ad75b8b7ef38edc0e346696c52e3d/crates/uv-resolver/src/pubgrub/report.rs#L509-L520
konstin
force-pushed
the
konsti/as-singleton
branch
from
587f547 to
fc14c5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this method for better error messages:
https://github.com/astral-sh/uv/blob/8d721830db8ad75b8b7ef38edc0e346696c52e3d/crates/uv-resolver/src/pubgrub/report.rs#L92-L96
https://github.com/astral-sh/uv/blob/8d721830db8ad75b8b7ef38edc0e346696c52e3d/crates/uv-resolver/src/pubgrub/report.rs#L509-L520