Add cold annotations

pubgrub-rs · Nov 22, 2024 · f0e4262 · f0e4262
1 parent 4ac6c42
commit f0e4262
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/src/internal/core.rs b/src/internal/core.rs
@@ -79,6 +79,7 @@ impl<DP: DependencyProvider> State<DP> {
     }
 
     /// Add an incompatibility to the state.
+    #[cold]
     pub(crate) fn add_incompatibility_from_dependencies(
         &mut self,
         package: Id<DP::P>,
@@ -105,6 +106,7 @@ impl<DP: DependencyProvider> State<DP> {
 
     /// Unit propagation is the core mechanism of the solving algorithm.
     /// CF <https://github.com/dart-lang/pub/blob/master/doc/solver.md#unit-propagation>
+    #[cold]
     pub(crate) fn unit_propagation(
         &mut self,
         package: Id<DP::P>,
@@ -187,6 +189,7 @@ impl<DP: DependencyProvider> State<DP> {
     /// Return the root cause or the terminal incompatibility.
     /// CF <https://github.com/dart-lang/pub/blob/master/doc/solver.md#unit-propagation>
     #[allow(clippy::type_complexity)]
+    #[cold]
     fn conflict_resolution(
         &mut self,
         incompatibility: IncompDpId<DP>,

diff --git a/src/internal/partial_solution.rs b/src/internal/partial_solution.rs
@@ -267,6 +267,7 @@ impl<DP: DependencyProvider> PartialSolution<DP> {
         }
     }
 
+    #[cold]
     pub(crate) fn pick_highest_priority_pkg(
         &mut self,
         prioritizer: impl Fn(Id<DP::P>, &DP::VS) -> DP::Priority,

diff --git a/src/provider.rs b/src/provider.rs
@@ -84,7 +84,6 @@ impl<P: Package, VS: VersionSet> DependencyProvider for OfflineDependencyProvide
 
     type Err = Infallible;
 
-    #[inline]
     fn choose_version(&self, package: &P, range: &VS) -> Result<Option<VS::V>, Infallible> {
         Ok(self
             .dependencies
@@ -94,7 +93,6 @@ impl<P: Package, VS: VersionSet> DependencyProvider for OfflineDependencyProvide
 
     type Priority = Reverse<usize>;
 
-    #[inline]
     fn prioritize(&self, package: &P, range: &VS) -> Self::Priority {
         Reverse(
             self.dependencies
@@ -104,7 +102,6 @@ impl<P: Package, VS: VersionSet> DependencyProvider for OfflineDependencyProvide
         )
     }
 
-    #[inline]
     fn get_dependencies(
         &self,
         package: &P,

diff --git a/src/solver.rs b/src/solver.rs
@@ -70,6 +70,7 @@ use crate::{DependencyConstraints, Map, Package, PubGrubError, SelectedDependenc
 
 /// Main function of the library.
 /// Finds a set of packages satisfying dependency bounds for a given package + version pair.
+#[cold]
 pub fn resolve<DP: DependencyProvider>(
     dependency_provider: &DP,
     package: DP::P,
-Original file line number
+Diff line change
@@ Expand Up / @@ -267,6 +267,7 @@ impl<DP: DependencyProvider> PartialSolution<DP> { @@
             }
         }
+        #[cold]
         pub(crate) fn pick_highest_priority_pkg(
             &mut self,
             prioritizer: impl Fn(Id<DP::P>, &DP::VS) -> DP::Priority,
@@ Expand Down @@