Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VsModal): fix dim click close #314

Merged
merged 2 commits into from
Jan 14, 2025
Merged

fix(VsModal): fix dim click close #314

merged 2 commits into from
Jan 14, 2025

Conversation

smithoo
Copy link
Collaborator

@smithoo smithoo commented Jan 14, 2025

Type of PR (check all applicable)

  • Fix Bug (fix)

Summary

vs-modal의 dim을 클릭 했을 때 modelValue가 업데이트 되지 않는 이슈를 수정합니다

Description

  • overlay-composable에서 initialOpen을 제거합니다
  • vs-modal-node에서 VS_OVERLAY_CLOSE callback을 덮어쓰는 버그를 수정합니다

@smithoo smithoo requested a review from yeriiiii January 14, 2025 07:00
@smithoo smithoo self-assigned this Jan 14, 2025
@smithoo smithoo merged commit 40e4cbb into release/1.0.8 Jan 14, 2025
7 checks passed
@smithoo smithoo deleted the fix/modal-dim branch January 14, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants