Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VsModalView): fix transition #313

Open
wants to merge 2 commits into
base: release/1.0.8
Choose a base branch
from
Open

fix(VsModalView): fix transition #313

wants to merge 2 commits into from

Conversation

yeriiiii
Copy link
Contributor

@yeriiiii yeriiiii commented Jan 9, 2025 •
edited
Loading

Type of PR (check all applicable)

  • Fix Bug (fix)

Summary

  • VsModal 구현 방법이 바뀌었으므로 transition 이 정상 작동하도록 수정합니다.
    • VsModalNode에서 <Transition/>을 제거하고 VsModalView에 <TransitionGroup/>을 추가. transition 관련 scss를 VsModalView.scss로 옮김

@yeriiiii yeriiiii requested a review from smithoo January 9, 2025 08:12
@yeriiiii yeriiiii changed the title fix(VsModal): add transition fix(VsModal): fix transition Jan 9, 2025
@yeriiiii yeriiiii self-assigned this Jan 9, 2025
@yeriiiii yeriiiii marked this pull request as ready for review January 9, 2025 08:14
@yeriiiii yeriiiii changed the title fix(VsModal): fix transition fix(VsModalView): fix transition Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smithoo smithoo Awaiting requested review from smithoo

At least 1 approving review is required to merge this pull request.

Assignees

@yeriiiii yeriiiii

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yeriiiii