Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Updating codemirror to version 5.39 #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updating codemirror to version 5.39 #10

wants to merge 1 commit into from

Conversation

aaimaawebs
Copy link

Hey,

Hows you. No updates for a long time? Hope everything fine.
I updated codemirror v5.23.0 to v5.39.0 !!

Hope pull request will help community to levrage the changes/fixes happens during 5.23 to 5.39.0 !! :)

@rg-
Copy link

rg- commented Mar 24, 2019

Hi, since Gutemberg, plugin seems not to update fields content, i ended up discovering that the new value is not passed to the orginal textarea, so once you save, changes are not saved.

But, on js/input.js, after editor.refresh();, adding this:

editor.on("change", function(cm, change) { 
	$textarea.val(editor.getValue()); 
});

Textarea value is saved.
What you think? Is safe to use this?

Using:
WP 5.1.1
ACF 5.7.13

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants