Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the present feature seems to require dri3 #945

Merged

Conversation

alexanderkjall
Copy link
Contributor

enables running: 'cargo test --no-default-features --features present'

Build on the work in: #944

@psychon
Copy link
Owner

psychon commented Nov 2, 2024

Can you fix this in Cargo.toml instead, please? That's how other such cases are handled as well.

diff --git a/x11rb-protocol/Cargo.toml b/x11rb-protocol/Cargo.toml
index a8aadb0b..72a5fd3d 100644
--- a/x11rb-protocol/Cargo.toml
+++ b/x11rb-protocol/Cargo.toml
@@ -76,7 +76,7 @@ dpms = []
 dri2 = []
 dri3 = []
 glx = []
-present = ["randr", "xfixes", "sync"]
+present = ["randr", "xfixes", "sync", "dri3"]
 randr = ["render"]
 record = []
 render = []

this enables running: 'cargo test --no-default-features --features present'
@alexanderkjall alexanderkjall force-pushed the present-feature-requires-dri3 branch from 527ddd9 to d2bc2c3 Compare November 5, 2024 15:49
@alexanderkjall
Copy link
Contributor Author

That is a much cleaner solution, thanks a lot :)

Copy link
Owner

@psychon psychon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit aafb75a into psychon:master Nov 5, 2024
11 checks passed
@alexanderkjall alexanderkjall deleted the present-feature-requires-dri3 branch November 5, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants