Use xcursor-rs for cursor theme parsing #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of reinventing the wheel, let's use an existing wheel for the same job: Parsing cursor theme files. This finished #934. A first step towards that goal was previously done in commit d0ed9db. Fixes: #934 Signed-off-by: Uli Schlachter <[email protected]>
I would have thought clippy already complains about this...? Or does the intermediate .map() confuse it, perhaps? Signed-off-by: Uli Schlachter <[email protected]>
I'm not sure if the new version really is simpler, but at least I got rid of an unwrap(). Signed-off-by: Uli Schlachter <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #938 +/- ##
==========================================
- Coverage 13.02% 12.60% -0.42%
==========================================
Files 191 191
Lines 137122 136422 -700
==========================================
- Hits 17860 17202 -658
+ Misses 119262 119220 -42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Should we make codecov merely informative (i.e., so it does not show CI as failed in commit or PR lists)? |
eduardosm
approved these changes
Aug 17, 2024
|
Uhm.... Can codecov actually do that? As far as I can tell, we have zero configuration of codecov and "it just does its thing". So I guess all I could do is to remove all its permissions for his repo... and even there I have no clue how to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use xcursor-rs for cursor theme parsing
Instead of reinventing the wheel, let's use an existing wheel for the
same job: Parsing cursor theme files.
This finished #934. A first step towards that goal was previously done
in commit d0ed9db.
Fixes: #934
After doing the above, I also came across some small simplifications that I also added to this PR.