Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the changelog for the next release #926

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Update the changelog for the next release #926

merged 1 commit into from
Apr 28, 2024

Conversation

psychon
Copy link
Owner

@psychon psychon commented Apr 28, 2024

Arguably, 39be186 is a breaking change since we cannot prevent access to the fields of the ...Cookie struct that is generated by atom_manager! invocations and these fields actually appeared in the docs. However, I can come up with zero reasons why anyone would mess with these fields directly and would like to pretend that this is not a breaking change. I documented it as one anyway.

Complaints?

Edit: Ref: #925

Copy link
Collaborator

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that this is a minor change

@mergify mergify bot merged commit d661ba3 into master Apr 28, 2024
21 checks passed
@mergify mergify bot deleted the changelog branch April 28, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants