Add remove() to bitmask_binop!

[psychon]

In this commit, I am adding a new function remove() to the bitmask_binop! macro. This function removes some set bits from the self instance.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6078dd4) 12.70% compared to head (a84efb5) 12.72%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
+ Coverage   12.70%   12.72%   +0.01%     
==========================================
  Files         189      189              
  Lines      139726   139752      +26     
==========================================
+ Hits        17750    17779      +29     
+ Misses     121976   121973       -3     

Flag	Coverage Δ
tests	12.72% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[notgull]

Looks good to be, but does this cause any significant compile-time regression?

[psychon]

but does this cause any significant compile-time regression?

Uhm... I looked at what #884 used for measurements and did it three times: for x in $(seq 1 3) ; do cargo clean && cargo build --no-default-features -F xfixes,randr,xkb,xinput ; done.

For master:

• Finished dev [unoptimized + debuginfo] target(s) in 57.97s
• Finished dev [unoptimized + debuginfo] target(s) in 57.95s
• Finished dev [unoptimized + debuginfo] target(s) in 57.99s

For this branch:

• Finished dev [unoptimized + debuginfo] target(s) in 57.82s
• Finished dev [unoptimized + debuginfo] target(s) in 58.27s
• Finished dev [unoptimized + debuginfo] target(s) in 58.06s

I'm not quite sure what do say from this... One of the branch builds was even faster.

Another round with -p x11rb-protocol added:

master:

• 18.63s
• 18.42s
• 18.75s

This branch:

• 18.66s
• 18.62s
• 19.24s

So... I guess the effect on build times is smaller than the noise here? But there might be an effect...

[notgull]

Good enough for me!