Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AsFd/AsSocket/etc. conversions #889

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

ids1024
Copy link
Contributor

@ids1024 ids1024 commented Oct 14, 2023

Generally these should be implemented anywhere the raw versions are.

Generally these should be implemented anywhere the raw versions are.
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (55ba7b0) 12.63% compared to head (8c7697d) 12.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
- Coverage   12.63%   12.63%   -0.01%     
==========================================
  Files         189      189              
  Lines      140382   140390       +8     
==========================================
  Hits        17736    17736              
- Misses     122646   122654       +8     
Flag Coverage Δ
tests 12.63% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
x11rb/src/xcb_ffi/mod.rs 23.32% <0.00%> (-0.16%) ⬇️
x11rb/src/rust_connection/stream.rs 4.54% <0.00%> (-0.10%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit 4fcd1c6 into psychon:master Oct 14, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants