reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835

reviewdog exited with status code: 1

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: giraffate/clippy-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

[clippy] reported by reviewdog 🐶 <pre><code>warning: usage of a legacy numeric method --> x11rb-protocol/src/connection/mod.rs:102:65 | 102 | if self.next_reply_expected + SequenceNumber::from(u16::max_value()) - 1 | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 102 | if self.next_reply_expected + SequenceNumber::from(u16::MAX) - 1 | ~~~ </code></pre> Raw Output: x11rb-protocol/src/connection/mod.rs:102:65:w: <pre><code>warning: usage of a legacy numeric method --> x11rb-protocol/src/connection/mod.rs:102:65 | 102 | if self.next_reply_expected + SequenceNumber::from(u16::max_value()) - 1 | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 102 | if self.next_reply_expected + SequenceNumber::from(u16::MAX) - 1 | ~~~ </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: usage of a legacy numeric method --> x11rb-protocol/src/connection/mod.rs:167:79 | 167 | let high_bytes = self.last_sequence_read & !SequenceNumber::from(u16::max_value()); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 167 | let high_bytes = self.last_sequence_read & !SequenceNumber::from(u16::MAX); | ~~~ </code></pre> Raw Output: x11rb-protocol/src/connection/mod.rs:167:79:w: <pre><code>warning: usage of a legacy numeric method --> x11rb-protocol/src/connection/mod.rs:167:79 | 167 | let high_bytes = self.last_sequence_read & !SequenceNumber::from(u16::max_value()); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 167 | let high_bytes = self.last_sequence_read & !SequenceNumber::from(u16::MAX); | ~~~ </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: usage of a legacy numeric method --> x11rb-protocol/src/connection/mod.rs:170:54 | 170 | full_number += SequenceNumber::from(u16::max_value()) + 1; | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 170 | full_number += SequenceNumber::from(u16::MAX) + 1; | ~~~ </code></pre> Raw Output: x11rb-protocol/src/connection/mod.rs:170:54:w: <pre><code>warning: usage of a legacy numeric method --> x11rb-protocol/src/connection/mod.rs:170:54 | 170 | full_number += SequenceNumber::from(u16::max_value()) + 1; | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 170 | full_number += SequenceNumber::from(u16::MAX) + 1; | ~~~ </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: usage of a legacy numeric method --> x11rb-protocol/src/connection/mod.rs:102:65 | 102 | if self.next_reply_expected + SequenceNumber::from(u16::max_value()) - 1 | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 102 | if self.next_reply_expected + SequenceNumber::from(u16::MAX) - 1 | ~~~ </code></pre> Raw Output: x11rb-protocol/src/connection/mod.rs:102:65:w: <pre><code>warning: usage of a legacy numeric method --> x11rb-protocol/src/connection/mod.rs:102:65 | 102 | if self.next_reply_expected + SequenceNumber::from(u16::max_value()) - 1 | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 102 | if self.next_reply_expected + SequenceNumber::from(u16::MAX) - 1 | ~~~ </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: usage of a legacy numeric method --> x11rb-protocol/src/connection/mod.rs:167:79 | 167 | let high_bytes = self.last_sequence_read & !SequenceNumber::from(u16::max_value()); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 167 | let high_bytes = self.last_sequence_read & !SequenceNumber::from(u16::MAX); | ~~~ </code></pre> Raw Output: x11rb-protocol/src/connection/mod.rs:167:79:w: <pre><code>warning: usage of a legacy numeric method --> x11rb-protocol/src/connection/mod.rs:167:79 | 167 | let high_bytes = self.last_sequence_read & !SequenceNumber::from(u16::max_value()); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 167 | let high_bytes = self.last_sequence_read & !SequenceNumber::from(u16::MAX); | ~~~ </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: usage of a legacy numeric method --> x11rb-protocol/src/connection/mod.rs:170:54 | 170 | full_number += SequenceNumber::from(u16::max_value()) + 1; | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 170 | full_number += SequenceNumber::from(u16::MAX) + 1; | ~~~ </code></pre> Raw Output: x11rb-protocol/src/connection/mod.rs:170:54:w: <pre><code>warning: usage of a legacy numeric method --> x11rb-protocol/src/connection/mod.rs:170:54 | 170 | full_number += SequenceNumber::from(u16::max_value()) + 1; | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 170 | full_number += SequenceNumber::from(u16::MAX) + 1; | ~~~ </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: usage of a legacy numeric method --> xtrace-example/src/connection.rs:109:52 | 109 | assert!(length_field <= usize::max_value() / 4); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 109 | assert!(length_field <= usize::MAX / 4); | ~~~ </code></pre> Raw Output: xtrace-example/src/connection.rs:109:52:w: <pre><code>warning: usage of a legacy numeric method --> xtrace-example/src/connection.rs:109:52 | 109 | assert!(length_field <= usize::max_value() / 4); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 109 | assert!(length_field <= usize::MAX / 4); | ~~~ </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: usage of a legacy numeric method --> xtrace-example/src/connection.rs:109:52 | 109 | assert!(length_field <= usize::max_value() / 4); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 109 | assert!(length_field <= usize::MAX / 4); | ~~~ </code></pre> Raw Output: xtrace-example/src/connection.rs:109:52:w: <pre><code>warning: usage of a legacy numeric method --> xtrace-example/src/connection.rs:109:52 | 109 | assert!(length_field <= usize::max_value() / 4); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 109 | assert!(length_field <= usize::MAX / 4); | ~~~ </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: usage of a legacy numeric method --> x11rb/src/xcb_ffi/mod.rs:577:27 | 577 | if id == u32::max_value() { | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 577 | if id == u32::MAX { | ~~~ </code></pre> Raw Output: x11rb/src/xcb_ffi/mod.rs:577:27:w: <pre><code>warning: usage of a legacy numeric method --> x11rb/src/xcb_ffi/mod.rs:577:27 | 577 | if id == u32::max_value() { | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 577 | if id == u32::MAX { | ~~~ </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: usage of a legacy numeric method --> x11rb/src/xcb_ffi/mod.rs:616:45 | 616 | let u32_max = SequenceNumber::from(u32::max_value()); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 616 | let u32_max = SequenceNumber::from(u32::MAX); | ~~~ </code></pre> Raw Output: x11rb/src/xcb_ffi/mod.rs:616:45:w: <pre><code>warning: usage of a legacy numeric method --> x11rb/src/xcb_ffi/mod.rs:616:45 | 616 | let u32_max = SequenceNumber::from(u32::max_value()); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 616 | let u32_max = SequenceNumber::from(u32::MAX); | ~~~ </code></pre> __END__