Record failure to find missing DOI (#699)

* Record failure to find missing DOI We’ll need publications that hit this branch of the DOI verification logic to be manually reviewed by an admin, so we need to set the flag appropriately to make that happen. * Rubocop --------- Co-authored-by: Alex Kiessling <[email protected]>
psu-libraries · Feb 15, 2023 · d4a4d4a · d4a4d4a
1 parent fb09c0a
commit d4a4d4a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/app/jobs/doi_verification_job.rb b/app/jobs/doi_verification_job.rb
@@ -13,6 +13,8 @@ def perform(publication_id)
       response = UnpaywallClient.query_unpaywall(publication)
       if publication.matchable_title == response.matchable_title && response.doi.present?
         publication.update!(doi: response.doi, doi_verified: true)
+      else
+        publication.update!(doi_verified: false)
       end
     end
   end

diff --git a/spec/component/jobs/doi_verification_job_spec.rb b/spec/component/jobs/doi_verification_job_spec.rb
@@ -67,8 +67,8 @@
             expect(publication.reload.doi).to be_nil
           end
 
-          it 'does not update the doi verification' do
-            expect(publication.reload.doi_verified).to be_nil
+          it 'updates the doi verification to false' do
+            expect(publication.reload.doi_verified).to be false
           end
         end
       end
@@ -83,8 +83,8 @@
           expect(publication.reload.doi).to be_nil
         end
 
-        it 'does not update the doi verification' do
-          expect(publication.reload.doi_verified).to be_nil
+        it 'updates the doi verification to false' do
+          expect(publication.reload.doi_verified).to be false
         end
       end
     end