Feat/sonar demo #112
Feat/sonar demo #112
Conversation
This reverts commit a349cd0.
* feat: add prototype pollution exploit in typeorm * fix: container and db setup
Sarif/checking scanning flow
sarif: testing scanning flow with sarif file
Create snyk-test-sarif.yml
sarif: testing of workflows
sarif: test on merge
Update sarif.json
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
SnykCode found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
| console.log(`User logged in: ${username}`) | ||
|
|
||
| if (redirectPage) { | ||
| return res.redirect(redirectPage) |
Check failure
Code scanning / SonarCloud
HTTP request redirections should not be open to forging attacks High
| app.use(session({ | ||
| secret: 'keyboard cat', | ||
| name: 'connect.sid', | ||
| cookie: { path: '/' } | ||
| })) |
Check failure
Code scanning / CodeQL
Missing CSRF middleware High
| cons.dust.helpers = dustHelpers; | ||
| app.set('views', path.join(__dirname, 'views')); | ||
| app.set('view engine', 'ejs'); | ||
| app.use(logger('dev')); | ||
| app.use(methodOverride()); | ||
| app.use(cookieParser()); | ||
| app.use(session({ | ||
| secret: 'keyboard cat', |
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical
| // You know password for the user. | ||
| {name: 'user', password: 'pwd'}, | ||
| // You don't know password for the admin. | ||
| {name: 'admin', password: Math.random().toString(32), canDelete: true}, |
Check failure
Code scanning / CodeQL
Insecure randomness High
| // You don't know password for the admin. | ||
| {name: 'admin', password: Math.random().toString(32), canDelete: true}, | ||
| { name: 'admin', password: Math.random().toString(32), canDelete: true }, |
Check failure
Code scanning / CodeQL
Insecure randomness High
| console.log(`User logged in: ${username}`) | ||
|
|
||
| if (redirectPage) { | ||
| return res.redirect(redirectPage) |
Check warning
Code scanning / CodeQL
Server-side URL redirect Medium
| @@ -14,6 +14,7 @@ | |||
| <center>password</center> | |||
| <input class="input" type="password" name="password" /> | |||
| <center> | |||
| <input type="hidden" name="redirectPage" value="<%- redirectPage %>" /> | |||
Check failure
Code scanning / CodeQL
Client-side cross-site scripting High
| profile.lastname = validator.rtrim(profile.lastname) | ||
|
|
||
| // render the view | ||
| return res.render('account.hbs', profile) |
Check failure
Code scanning / CodeQL
Template Object Injection Critical
| subhead: 'Vulnerabilities at their best', | ||
| todos: todos, | ||
| }); | ||
| }); | ||
| }; | ||
|
|
||
| exports.loginHandler = function (req, res, next) { | ||
| if (validator.isEmail(req.body.username)) { | ||
| User.find({ username: req.body.username, password: req.body.password }, function (err, users) { |
Check failure
Code scanning / CodeQL
Database query built from user-controlled sources High
| app.get('/admin', routes.admin); | ||
| app.post('/admin', routes.admin); | ||
| app.get('/login', routes.login); | ||
| app.post('/login', routes.loginHandler); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| @@ -79,7 +154,7 @@ | |||
|
|
|||
| var item = req.body.content; | |||
| var imgRegex = /\!\[alt text\]\((http.*)\s\".*/; | |||
| if (typeof(item) == 'string' && item.match(imgRegex)) { | |||
| if (typeof (item) == 'string' && item.match(imgRegex)) { | |||
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
Creating issue for failing quality gate