Add stubs for Symfony 7 #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not completely true. There are no Symfony 7 specific stubs; common stubs are applied for all versions including Symfony 7.
LGTM |
seferov
approved these changes
Jun 22, 2024
jmglsn
reviewed
Jul 2, 2024
| * @template TType of string|class-string<TObject> | ||
| * | ||
| * @psalm-param TType $type | ||
| * @psalm-return (TType is class-string<TObject> ? TObject : mixed) |
There was a problem hiding this comment.
I believe it should be ok to return null as well, WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are no stubs for Symfony v7, closes #347.
I'm not exactly sure what needs to be done here, or if anything needs to be done at all. I've split the PR into two commits. In the first commit, I copied the stubs from v7. In the second, I synced the code with what is in Symfony. I'm not sure if this is actually necessary. I also checked if there have been any updates to the docblocks for these functions, but as far as I could tell, nothing has changed.