Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shellcheck test action #108

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add shellcheck test action #108

wants to merge 8 commits into from

Conversation

miigotu
Copy link
Member

@miigotu miigotu commented Mar 20, 2021

Signed-off-by: miigotu [email protected]

@miigotu miigotu force-pushed the docker-shellcheck branch 4 times, most recently from 846798d to 4aae8de Compare March 21, 2021 03:20
@miigotu miigotu force-pushed the docker-shellcheck branch from 07ad006 to d00acf1 Compare March 21, 2021 04:32
@miigotu miigotu force-pushed the docker-shellcheck branch from 14f23de to 74e2cdf Compare March 21, 2021 04:52
@zeldin
Copy link
Member

zeldin commented Mar 21, 2021

Looks like the Docker build is running out of disk space. Can you allocate more to it?

@miigotu
Copy link
Member Author

miigotu commented Mar 21, 2021

@zeldin nope, they have a pre set allotment for the runner containers. I think I need to not cache locally for layer caching of buildx, and if that isn't enough I will have to separate different architectures into different builds like before buildx existed. I worked on it all day yesterday, I'll try some more later on.

@miigotu miigotu force-pushed the docker-shellcheck branch from b1c0849 to 456454a Compare March 23, 2021 10:35
…ce we aren't building for either.

Add action to manually delete old workflows
@miigotu miigotu force-pushed the docker-shellcheck branch from 456454a to 94783ee Compare March 23, 2021 10:36
@miigotu
Copy link
Member Author

miigotu commented Mar 23, 2021

@zeldin, fixed. Just need secrets set for docker username/pass and enable ghcr for ps3dev

I'd also like to pull the toolchains out of each image and make them available as tar artifacts for download right from the build, and use the action that makes releases

@miigotu
Copy link
Member Author

miigotu commented Apr 2, 2021

Lol I think I figured out why the push fails for me, docker config is cached between all my builds even on other orgs, so it tries to login to ps3dev/ps3dev with my credentials for sickchill/sickchill ;) I had the same problem over there and fixed it, will update this PR soon as I solve an issue upgrading my other packages on synology.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants