Update block Beacon APIs to Electra #14488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of #14476 |
saolyn
previously approved these changes
Oct 1, 2024
james-prysm
reviewed
Oct 1, 2024
| httputil.HandleError(w, err.Error(), http.StatusInternalServerError) | ||
| return | ||
| } | ||
| httputil.WriteSsz(w, sszResp, "blindedDenebBlockContents.ssz") |
There was a problem hiding this comment.
this says blinded deneb
james-prysm
reviewed
Oct 1, 2024
| httputil.HandleError(w, err.Error(), http.StatusInternalServerError) | ||
| return | ||
| } | ||
| httputil.WriteSsz(w, sszResp, "denebBlockContents.ssz") |
james-prysm
reviewed
Oct 1, 2024
proto/eth/v2/grpc.ssz.go
Outdated
| @@ -1,5 +1,5 @@ | |||
| // Code generated by fastssz. DO NOT EDIT. | |||
| // Hash: bc8a0f7f6c8dadac6bcb0eaab2dea4888cc44c5b3f4fe9998a71e15f1a059399 | |||
| // Hash: 972fffced75dd107ea15cf7ca6f49458de90b0e9ec83538fa0d106e85d5f60de | |||
james-prysm
reviewed
Oct 1, 2024
| @@ -136,7 +136,8 @@ ssz_electra_objs = [ | |||
| "AggregateAttestationAndProofElectra", | |||
| "AttestationElectra", | |||
| "AttesterSlashingElectra", | |||
| "BeaconBlockElectra", | |||
| "BeaconBlockBodyElectra", | |||
| "BeaconBlockContentsElectra", | |||
There was a problem hiding this comment.
why is blinded block contents not needed?
There was a problem hiding this comment.
This is because (weirdly) https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Validator/produceBlockV3 returns full contents for a non-blinded block and only the block in the blinded case.
# Conflicts: # CHANGELOG.md
james-prysm
approved these changes
Oct 2, 2024
|
we need to update the validator rest to use the new v3 endpoint right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the following endpoints to Electra: