New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W & H added to customise #2

Open

ravivlb wants to merge 1 commit into prscX:master from ravivlb:master

ravivlb commented Feb 20, 2018

I have added the width and height to customise based on user


          W & H added to customise

08e406a

Owner

prscX commented Feb 20, 2018

Thanks @ravivlb for the PR.

Definitely it make sense to have a customise layer for the container size. Before merging PR I have couple of questions:

You have made changes in style but we are also passing size prop to native. Do we have to change their also? If yes then we can completely get rid of size prop and introduce width & height as default props.
Should we add width & height prop to class prop types as well and also provide some default value to the same?
Just by changing in style is it working as expected for you?

Thanks
Pranav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet