Fixed a spelling mistake #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might as well just return the result of the comparison. No change in behaviour but it makes the code just a little bit cleaner.
When using quickswitch with workspaces, it's very helpful to be able to create new ones on the fly using the same i3 bindings as you would for when dealing with pre-existing ones. When no target is found in the lookup table, this patch overrides the lookup result and simply uses whatever workspace name the user supplied. In my view, this behaviour is much more intuitive, and tremendously helpful.
This patch adds the possiblity to combine -m and -w to move the current container to the selected workspace. I personally feel that the feature is exceedingly helpful, but I'm not entirely sure that overloading the -m option in this way is desirable.
Since we have the -d/--dmenu option we shouldn't be too sure about the binary name of dmenu.
Conflicts: quickswitch.py
Conflicts: quickswitch.py
Conflicts: quickswitch.py
That is to say, workspaces with names like "4:irc" or "5 compilation" or "1vim".
Conflicts: quickswitch.py
Also add cooperation between -j and -r, similarly to how -m and -r work together.
Added window class if not already present, and mark
Add suffix of "(_id)" to windows with the same name as a previous window.
Absent window names shouldn't break quickswitch
Conflicts: quickswitch.py
Conflicts: quickswitch.py setup.py
This automatically provide /usr/bin/quickswitch
Add an entrypoint to the setup call
Proposal for a source-code cleanup with flake8
Add follow options
Add `i3_py` to setuptools `install_requires`. Causes it to be installed when quickswitch is installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:)