Fix Debian-specific checking for dmenu. #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old check uses ``which``, which is a Debian-specific tool. The new one invokes ``dmenu -v`` straight away, so it doesn't depend on external tools. It's compatible with both Python 3 and Python 2. It also fixes opening ``/dev/null`` in write mode instead of read-only, plus it uses ``with`` to ensure that the file is closed.
|
It looks like I see there is already a simpler patch in #24, so I'm closing the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old check uses
which, which is a Debian-specific tool. The new oneinvokes
dmenu -vstraight away, so it doesn't depend on external tools.It's compatible with both Python 3 and Python 2.
It also fixes opening
/dev/nullin write mode instead of read-only, plusit uses
withto ensure that the file is closed.