Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asset-cfg-tx): allow params to be optional in that #16

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

gskapka
Copy link
Collaborator

@gskapka gskapka commented Jan 22, 2024

...per title.

Algorand allows empty params in such a tx so as to signify the destruction of said asset (See here in go-algorand)

@gskapka gskapka self-assigned this Jan 22, 2024
@gskapka gskapka requested a review from oliviera9 January 22, 2024 11:15
oliviera9
oliviera9 previously approved these changes Jan 22, 2024
Copy link
Collaborator

@oliviera9 oliviera9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gskapka gskapka force-pushed the fix-optional-asset-config-params branch from c5474c1 to bda491e Compare January 22, 2024 11:36
@gskapka gskapka requested a review from oliviera9 January 22, 2024 11:36
oliviera9
oliviera9 previously approved these changes Jan 22, 2024
Copy link
Collaborator

@oliviera9 oliviera9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/algorand_transactions/test_utils/mod.rs Show resolved Hide resolved
@gskapka gskapka force-pushed the fix-optional-asset-config-params branch from bda491e to 1c9dc53 Compare January 22, 2024 11:43
@gskapka gskapka merged commit 07de203 into master Jan 22, 2024
3 checks passed
@gskapka gskapka deleted the fix-optional-asset-config-params branch January 22, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants