feat: direct audio proxy file writing #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating an audio proxy file for an FFmpeg stream, it was first fully decoded and stored in memory before it was written to a file. This was an inefficient waste of memory resources, and proxy files were limited to a size of 2 GiB due to a limitation of .NET's `MemoryStream`. With this change, the files are written directly. They are now limited to 4 GiB due to a limitation of NAudio's `WaveFileWriter`.
protyposis
force-pushed
the
feat/direct-proxy-files
branch
from
022d1f2
to
0e1779c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating an audio proxy file for an FFmpeg stream, it was first fully decoded and stored in memory before it was written to a file. This was an inefficient waste of memory resources, and proxy files were limited to a size of 2 GiB due to a limitation of .NET's
MemoryStream. With this change, the files are written directly. They are now limited to 4 GiB due to a limitation of NAudio'sWaveFileWriter.