Liq rewards proposals #2205
Liq rewards proposals #2205
Conversation
…ner to prevent dupe code
|
In order to have not stretched components like this we need to give the text box a fixed height of 54px and align the text vertically centered. currently: should: for mobile we can remove the height property as we don`t need to take care of equal heights anymore: |
|
Now that we have our clearly defined text styles, we should start using them: |
| import React from 'react' | ||
|
|
||
| export const IconBack = () => ( | ||
| <svg fill="none" height="12" viewBox="0 0 18 12" width="18" xmlns="http://www.w3.org/2000/svg"> | ||
| <path d="M18 5H3.83L7.41 1.41L6 0L0 6L6 12L7.41 10.59L3.83 7H18V5Z" /> | ||
| </svg> | ||
| ) |
There was a problem hiding this comment.
I don't think its necessary to import another Icon here I used on my proposal details pr IconArrowBack with slight modification to support this color https://github.com/protofire/omen-exchange/pull/2208/files#
There was a problem hiding this comment.
Cheers dude, copied!
app/src/components/guild/index.tsx
Outdated
| import { BigNumber } from 'ethers/utils' | ||
| import React, { useEffect, useState } from 'react' | ||
| import styled from 'styled-components' | ||
|
|
There was a problem hiding this comment.
Great that you created guild in the components folder I did the same thing on mine! Also In order to keep separation of concerns I think it might make sense to create guild folder inside pages folder and store all the logic there and separate it from view which will be stored in components? Curios what you and Kaden think about this and how we should go about it...You can also checkout maybe how I did it and if it makes sense or if we should do It differently.... @kadenzipfel @hexyls
There was a problem hiding this comment.
I really like this idea, made a proposed_rewards_page.tsx and a proposed_rewards_view.tsx, much better now
app/src/components/guild/index.tsx
Outdated
| const ProposalTitle = styled.div` | ||
| font-size: 22px; | ||
| font-weight: 500; | ||
| line-height: 26px; | ||
| color: ${props => props.theme.text3}; |
There was a problem hiding this comment.
Also for all the text files we should be using new TYPE.something from theme/index.js file It is now on master with recent pr from francesco that we pushed...
There was a problem hiding this comment.
done 🏄♂️ was cool putting TYPE into action, pretty powerful and easy to use
There was a problem hiding this comment.
right! Its so dope and easy to copy from figma and not have to worry about text style
|
@hexyls Hey men I started working on this issue #2128 for and found that you have similar table like the one in proposal details view...This table... |
closes #2044