New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type information that TSLint needs for some rules #25

Open

fvictorio wants to merge 3 commits into master from add-type-info-tslint

Contributor

fvictorio commented Jan 29, 2019

This PR also disables some rules:

no-unnecessary-type-assertion was giving a false positive in this line. There's an open issue here.
completed-docs is annoying, do we really want docs for exported actions?
promise-function-async adds unnecessary boilerplate, specially when dispatching async actions.

fvictorio added 2 commits

January 29, 2019 17:08


          Add type information to TSLint

544a06b


          Disable some linter rules

fvictorio requested a review from unjapones

January 29, 2019 20:12


          Use 0x-codesandbox tsconfig.json.

8f14161

Contributor

unjapones commented Jan 29, 2019

Heh :). I gave priority to 0x-codesandbox's tsconfig.json and overwrote the file.

unjapones approved these changes

View reviewed changes

pablofullana added the in progress label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels