Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate RepeatedFieldBuilderV3 with @Deprecated. #20030

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benjaminp
Copy link
Contributor

This silences a javac lint:

java/core/src/main/java/com/google/protobuf/RepeatedFieldBuilderV3.java:28: warning: [dep-ann] deprecated item is not annotated with @Deprecated
public class RepeatedFieldBuilderV3<
       ^

@benjaminp benjaminp requested a review from a team as a code owner January 17, 2025 20:48
@benjaminp benjaminp requested review from shaod2 and removed request for a team January 17, 2025 20:48
@benjaminp benjaminp changed the title Annotate RepeatedFieldBuilderV3 with @RepeatedFieldBuilderV3. Annotate RepeatedFieldBuilderV3 with @Deprecated. Jan 17, 2025
This silences a javac lint:
```
java/core/src/main/java/com/google/protobuf/RepeatedFieldBuilderV3.java:28: warning: [dep-ann] deprecated item is not annotated with @deprecated
public class RepeatedFieldBuilderV3<
       ^
```
@shaod2 shaod2 added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jan 20, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jan 20, 2025
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jan 23, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants