Fix wrong integer en- and decoding in protobuf-c-text library. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwegge
commented
Nov 18, 2014
bwegge
commented
- int{32,64} should be treated as signed integers (see https://developers.google.com/protocol-buffers/docs/proto#scalar)
- [u]int64 are [unsigned] long long integers on 32 bit platforms. The second patch uses inttypes.h macros for a compatible way to printf these integers, but this probably needs C99 where inttypes.h was officially introduced.
added 2 commits
November 19, 2014 12:00
[u]int64 is [unsigned] long *or* long long depending on the word size. Use inttypes.h macros (C99) to use correct encoding on all architectures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.