fix auth providers

prostgles · Nov 24, 2024 · f36b518 · f36b518
1 parent e105c3c
commit f36b518
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 17 deletions.
diff --git a/lib/Auth/AuthTypes.ts b/lib/Auth/AuthTypes.ts
@@ -36,18 +36,16 @@ export type AuthClientRequest = { socket: PRGLIOSocket } | { httpReq: ExpressReq
 
 type ThirdPartyProviders = {
   facebook?: Pick<FacebookStrategy, "clientID" | "clientSecret"> & {
-    // appId: string;
-    // appSecret: string;
-    authOpts: AuthenticateOptions;
+    authOpts?: AuthenticateOptions;
   };
   google?: Pick<GoogleStrategy, "clientID" | "clientSecret"> & {
-    authOpts: AuthenticateOptions;
+    authOpts?: AuthenticateOptions;
   };
   github?: Pick<GitHubStrategy, "clientID" | "clientSecret"> & {
-    authOpts: AuthenticateOptions;
+    authOpts?: AuthenticateOptions;
   };
   microsoft?: Pick<MicrosoftStrategyOptions, "clientID" | "clientSecret"> & {
-    authOpts: AuthenticateOptions;
+    authOpts?: AuthenticateOptions;
   };
 };
 

diff --git a/lib/Auth/setAuthSignup.ts b/lib/Auth/setAuthSignup.ts
@@ -69,7 +69,7 @@ export const setAuthSignup = ({ registrations, app }: Required<Auth>["expressCon
     );
 
     app.get(`/auth/${providerName}`,
-      passport.authenticate(providerName, authOpts)
+      passport.authenticate(providerName, authOpts ?? {})
     );
 
     app.get(callbackPath,
@@ -84,7 +84,11 @@ export const setAuthSignup = ({ registrations, app }: Required<Auth>["expressCon
 
 export const getProviders = (registrations: Required<Auth>["expressConfig"]["registrations"]): AuthSocketSchema["providers"] | undefined => {
   if(!registrations) return undefined;
-  const { email, websiteUrl, onRegister, ...providers } = registrations;
+  const { 
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    email, websiteUrl, onRegister, 
+    ...providers 
+  } = registrations;
   if(isEmpty(providers)) return undefined;
 
   const result: AuthSocketSchema["providers"] = {}

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "prostgles-server",
-  "version": "4.2.137",
+  "version": "4.2.138",
   "description": "",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/tests/client/package-lock.json b/tests/client/package-lock.json
diff --git a/tests/client/package.json b/tests/client/package.json
@@ -13,7 +13,7 @@
   "license": "ISC",
   "dependencies": {
     "@types/node": "^20.9.2",
-    "prostgles-client": "^4.0.145",
+    "prostgles-client": "^4.0.146",
     "prostgles-types": "^4.0.51",
     "socket.io-client": "^4.7.5"
   },

diff --git a/tests/server/package-lock.json b/tests/server/package-lock.json