fix auth session

prostgles · Nov 25, 2024 · 4bf21a2 · 4bf21a2
1 parent c33f767
commit 4bf21a2
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/lib/Auth/AuthTypes.ts b/lib/Auth/AuthTypes.ts
@@ -124,11 +124,11 @@ export type AuthRegistrationConfig = RegistrationProviders & {
    * Used to stop abuse
    */
   onProviderLoginStart: (data: { provider: IdentityProvider; req: ExpressReq, res: ExpressRes}, client: LoginClientInfo) => Promise<{ error: string; } | { ok: true; }>;
-  
+
   /**
    * Used to identify abuse
    */
-  onProviderLoginFail: (data: { provider: IdentityProvider; error: any, req: ExpressReq, res: ExpressRes}) => void | Promise<void>;
+  onProviderLoginFail: (data: { provider: IdentityProvider; error: any, req: ExpressReq, res: ExpressRes}, client: LoginClientInfo) => void | Promise<void>;
 };
 
 export type SessionUser<ServerUser extends UserLike = UserLike, ClientUser extends UserLike = UserLike> = {

diff --git a/lib/Auth/setAuthProviders.ts b/lib/Auth/setAuthProviders.ts
@@ -90,7 +90,8 @@ export function setAuthProviders (this: AuthHandler, { registrations, app }: Req
       callbackPath,
       async (req, res) => {
         try {
-          const startCheck = await onProviderLoginStart({ provider: providerName, req, res }, getLoginClientInfo({ httpReq: req }));
+          const clientInfo = getLoginClientInfo({ httpReq: req });
+          const startCheck = await onProviderLoginStart({ provider: providerName, req, res }, clientInfo);
           if("error" in startCheck){
             res.status(500).json({ error: startCheck.error });
             return;
@@ -104,7 +105,7 @@ export function setAuthProviders (this: AuthHandler, { registrations, app }: Req
             },
             async (error: any, _profile: any, authInfo: any) => {
               if(error){
-                await onProviderLoginFail({ provider: providerName, error, req, res });
+                await onProviderLoginFail({ provider: providerName, error, req, res }, clientInfo);
                 res.status(500).json({
                   error: "Failed to login with provider",
                 });

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "prostgles-server",
-  "version": "4.2.148",
+  "version": "4.2.149",
   "description": "",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/tests/server/package-lock.json b/tests/server/package-lock.json