Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update prost to v0.13 #225

Closed

Conversation

koushiro
Copy link
Contributor

@koushiro koushiro commented Sep 19, 2024

Close #227
Close #228
Close #229

@koushiro
Copy link
Contributor Author

BTW, I tried to add features to support multiple versions of prost like below, although prost_build::Config provides the prost_path method, it still fails.

[features]
default = []
protobuf = ["protobuf-0_13"]
protobuf-0_12 = ["dep:prost-0_12", "dep:prost-types-0_12", "dep:prost-build-0_12"]
protobuf-0_13 = ["dep:prost-0_13", "dep:prost-types-0_13", "dep:prost-build-0_13"]

[dependencies]
dtoa = "1.0"
itoa = "1.0"
parking_lot = "0.12"
prometheus-client-derive-encode = { version = "0.4.1", path = "derive-encode" }
prost-0_12 = { package = "prost", version = "0.12", optional = true }
prost-types-0_12 = { package = "prost-types", version = "0.12", optional = true }
prost-0_13 = { package = "prost", version = "0.13", optional = true }
prost-types-0_13 = { package = "prost-types", version = "0.13", optional = true }

[build-dependencies]
cfg-if = "1.0.0"
prost-build-0_12 = { package = "prost-build", version = "0.12", optional = true }
prost-build-0_13 = { package = "prost-build", version = "0.13", optional = true }

@koushiro
Copy link
Contributor Author

koushiro commented Sep 19, 2024

@mxinden
Do you think we should upgrade prost to 0.13 directly in version 0.23, or should we do it in the next version 0.24?
And do you have a plan to release v0.23.0?

@koushiro koushiro changed the title deps: update prost to v0.13.2 deps: update prost to v0.13 Sep 24, 2024
Signed-off-by: koushiro <[email protected]>
@koushiro koushiro closed this Dec 27, 2024
@koushiro koushiro deleted the update-prost-v0.13 branch December 27, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant