Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): add axum example #219

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

j3rrywan9
Copy link
Contributor

No description provided.

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thank you.

Can you address the CI failures? Otherwise, this looks good to me.

examples/axum.rs Outdated

Response::builder()
.status(StatusCode::OK)
.header(CONTENT_TYPE, "application/openmetrics-text; version=1.0.0; charset=utf-8")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@j3rrywan9
Copy link
Contributor Author

@mxinden Thanks for the review! I've fixed all the issues called out by cargo fmt

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mxinden mxinden merged commit 3e6579b into prometheus:master Aug 4, 2024
10 checks passed
@j3rrywan9 j3rrywan9 deleted the axum-example branch August 4, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants