-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(portability): Support all platforms without 64 bit atomics #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target_has_atomic
is neat! Thank you @navaati. Good work.
Do you have experience cross-compiling Rust for RISC-V? If so, want to add another target
to the matrix here within this pull request?
client_rust/.github/workflows/rust.yml
Lines 160 to 178 in bf196d7
cross-compile: | |
name: Cross compile | |
runs-on: ubuntu-latest | |
strategy: | |
matrix: | |
target: | |
- armv7-unknown-linux-gnueabihf | |
- powerpc-unknown-linux-gnu | |
- powerpc64-unknown-linux-gnu | |
- wasm32-unknown-unknown | |
steps: | |
- uses: actions/checkout@v2 | |
- uses: dtolnay/rust-toolchain@stable | |
with: | |
target: ${{ matrix.target }} | |
# Note that this does not test the `protobuf` feature (for now). See reasoning in https://github.com/prometheus/client_rust/pull/98/. | |
- run: cargo check --target=${{ matrix.target }} |
Ah, yes. It very much depends on the support from that Github Action you use, which I’m not super familiar with. The target I actually use, I’ll put out a commit with |
Yep. Will do. Thanks. |
Also note, you will need to sign off your commits, see failing CI step. |
346744b
to
56e6b3c
Compare
Just triggered a CI run. |
Thanks. And it fails, as I feared the target needs the rust-std component and it’s nightly only… But you have powerpc and wasm32 which are 32-bit platforms, so it should be ok. Should I just drop that CI commit and we go as is ? |
Notably, RISC-V 32 for ESP32-C3 chips. Signed-off-by: Léo Gillot-Lamure <[email protected]>
56e6b3c
to
4129bb0
Compare
I’ve done that. Let’s merge as-is if you’re good with it ! |
Signed-off-by: Max Inden <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
Notably, RISC-V 32 for ESP32-C3 chips. Fixes #201. Closes #202.