chore(examples/hyper): Port to hyper 1.x #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levaitamas
force-pushed
the
examples-hyper-1
branch
from
779481b to
b4e6e69
Compare
mxinden
reviewed
Apr 24, 2024
Cargo.toml
Outdated
| @@ -35,7 +35,9 @@ rand = "0.8.4" | |||
| tide = "0.16" | |||
| actix-web = "4" | |||
| tokio = { version = "1", features = ["rt-multi-thread", "net", "macros", "signal"] } | |||
| hyper = { version = "0.14.16", features = ["server", "http1", "tcp"] } | |||
| hyper = { version = "1.3.1", features = ["server", "http1"] } | |||
| hyper-util = { version = "0.1.3", features = ["full"] } | |||
There was a problem hiding this comment.
Are all features required? E.g. the client feature?
There was a problem hiding this comment.
Nice catch! Feature tokio is sufficient. Fixed in 043fdd3.
levaitamas
force-pushed
the
examples-hyper-1
branch
from
e25e02e to
043fdd3
Compare
|
Thanks for the follow-up! Can you fix the CI rustfmt failure @levaitamas? Otherwise this is good to merge. |
Based on prometheus#184 Co-authored-by: Jun Kurihara <[email protected]> Signed-off-by: Tamas Levai <[email protected]>
Signed-off-by: Tamas Levai <[email protected]>
Signed-off-by: Tamas Levai <[email protected]>
levaitamas
force-pushed
the
examples-hyper-1
branch
from
aad435f to
c524c73
Compare
Thanks! Fixed in c524c73. |
mxinden
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the hyper example to hyper 1.x.
All kudos goes to @junkurihara (#184).
Closes the erroneous #187.