feat(encoding): new encode_registry and encode_end functions to compose cross-registry responses
#154
Conversation
|
Yes, sorry. I still need to get around to finishing this. I am actively workings on metrics that will require this PR. Sorry for the delay! |
…ompose cross-registry responses Signed-off-by: Adam Cimarosti <[email protected]>
|
Changes are now ready for re-reviewing. Thanks for your feedback! |
amunra
changed the title
parts::* functions to compose cross-registry responsesencode_registry and encode_end functions to compose cross-registry responses
|
@mxinden Hi Max, I hope you don't mind pinging you :-). |
Co-authored-by: Max Inden <[email protected]> Signed-off-by: Adam Cimarosti <[email protected]>
|
@mxinden Sorry for the delay, I was away on holiday. Updated as per your suggestions. |
|
Note that you are missing the DCO sign-off. Would you mind either signing off each of your commits, or squashing into a single signed-off commit? Either way, this pull request will be squashed into master. |
I have no idea what that means. |
|
@amunra sorry for the incomplete message and the delay. You have a set of instructions when you click https://github.com/prometheus/client_rust/pull/154/checks?check_run_id=19282972846 I am sorry for the inconvenience this is causing. I know it is annoying. |
|
Hello, I'll be honest here: I'm pretty bogged down with quite a number of other items of work and I'll doubt I'll realistically get around to ever understanding/completing the DCO bureaucracy around this PR to be able to get it into a mergeable state. If anyone else has the energy to create a new PR I get the feeling that the @mxinden will likely accept the change (or at least I hope) since it's effectively code + test + review -complete. I'm sorry I'm leaving this 98% done, but I don't have the mental energy necessary here. I waive any rights / attribution etc over the code changes here (as I also mentioned in the PR description). Any help to get this over the finish line would be most welcome and I thank in advance. |
All credits on the initial idea, implementation, and testing belong to @amunra, who is the original author of this PR prometheus#154. From the original PR description: Adds new `encode_registry` and `encode_eof` functions to allow encoding of parts of the response. This is useful when there are multiple registries at play, or when composing metrics for a process that embeds Rust as part of its logic whilst serving metrics to Prometheus outside of Rust. Fixes: prometheus#153 Refs: prometheus#154, prometheus#204 Co-authored-by: Adam Cimarosti <[email protected]> Signed-off-by: Tyrone Wu <[email protected]>
All credits on the initial idea, implementation, and testing belong to @amunra, who is the original author of this PR prometheus#154. From the original PR description: Adds new `encode_registry` and `encode_eof` functions to allow encoding of parts of the response. This is useful when there are multiple registries at play, or when composing metrics for a process that embeds Rust as part of its logic whilst serving metrics to Prometheus outside of Rust. Fixes: prometheus#153 Refs: prometheus#154, prometheus#204 Co-authored-by: amunra <[email protected]> Signed-off-by: tyrone-wu <[email protected]>
All credits on the initial idea, implementation, and testing belong to @amunra, who is the original author of this PR prometheus#154. From the original PR description: Adds new `encode_registry` and `encode_eof` functions to allow encoding of parts of the response. This is useful when there are multiple registries at play, or when composing metrics for a process that embeds Rust as part of its logic whilst serving metrics to Prometheus outside of Rust. Fixes: prometheus#153 Refs: prometheus#154, prometheus#204 Co-authored-by: amunra <[email protected]> Signed-off-by: tyrone-wu <[email protected]>
All credits on the initial idea, implementation, and testing belong to @amunra, who is the original author of this PR prometheus#154. From the original PR description: Adds new `encode_registry` and `encode_eof` functions to allow encoding of parts of the response. This is useful when there are multiple registries at play, or when composing metrics for a process that embeds Rust as part of its logic whilst serving metrics to Prometheus outside of Rust. Fixes: prometheus#153 Refs: prometheus#154, prometheus#204 Co-authored-by: amunra <[email protected]> Signed-off-by: tyrone-wu <[email protected]>
#205) All credits on the initial idea, implementation, and testing belong to @amunra, who is the original author of this PR #154. From the original PR description: Adds new `encode_registry` and `encode_eof` functions to allow encoding of parts of the response. This is useful when there are multiple registries at play, or when composing metrics for a process that embeds Rust as part of its logic whilst serving metrics to Prometheus outside of Rust. Fixes: #153 Refs: #154, #204 Co-authored-by: amunra <[email protected]> Signed-off-by: tyrone-wu <[email protected]> Signed-off-by: Max Inden <[email protected]>
|
Closing here with #205 merged. |
New
encode_registryandencode_endfunctions allow encoding only parts of the response.This is useful when there are multiple registries at play, or when composing metrics for a process that embeds Rust as part of its logic whilst serving metrics to Prometheus outside of Rust.
Closes #153
I wish to waive any ownership rights for the changes included in this PR and I'm happy for you to license these changes in any way you see fit, including the MIT and Apache licenses. Once accepted these changes are of your ownership.