chore!: adopt slog, drop go-kit/log #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bulk of this change set was automated by the following script which is being used to aid in converting the various exporters/projects to use slog: https://gist.github.com/tjhop/49f96fb7ebbe55b12deee0b0312d8434 Other changes include: - bumping prometheus/{common,client_golang,exporter-toolkit} - bump minimum go version to go1.22 - remove old go-kit/log linter configs, add sloglint Signed-off-by: TJ Hoplock <[email protected]>
|
cc: @SuperQ |
SuperQ
approved these changes
Oct 18, 2024
k0ste
added a commit
to k0ste/smartctl_exporter
that referenced
this pull request
Dec 19, 2024
* [CHANGE] `slog` used for logging instead go logger prometheus-community#246 * [ENHANCEMENT] Added support for `megaraid` devices and device types prometheus-community#205 prometheus-community#257 * [BUGFIX] Better support for smartmontools < 7.3 prometheus-community#238 * [BUGFIX] Corrected NVMe read/write bytes to NVMe metrics prometheus-community#211 Signed-off-by: Konstantin Shalygin <[email protected]>
Merged
SuperQ
pushed a commit
that referenced
this pull request
Dec 20, 2024
* [CHANGE] `slog` used for logging instead go logger #246 * [ENHANCEMENT] Added support for `megaraid` devices and device types #205 #257 * [BUGFIX] Better support for smartmontools < 7.3 #238 * [BUGFIX] Corrected NVMe read/write bytes to NVMe metrics #211 Signed-off-by: Konstantin Shalygin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk of this change set was automated by the following script which
is being used to aid in converting the various exporters/projects to use
slog:
https://gist.github.com/tjhop/49f96fb7ebbe55b12deee0b0312d8434
Other changes include:
Signed-off-by: TJ Hoplock [email protected]