Added more testdata json's #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robbat2 hope this helps for CI |
|
@k0ste that's amazing data, thanks! 139 different drive models! I see we need some tweaks to the scripts: I think the filenames shouldn't contain Was the model_family getting the three dots here a redaction bug? Seems to affect only Toshiba drives. Filenames:
Tells me you have at least one very large disk chassis. |
k0ste
added a commit
to k0ste/smartctl_exporter
that referenced
this pull request
Dec 30, 2023
* Remove `"`, `(` and `)` from file names (see prometheus-community#188) * Added regex ignore for some devices, fixes: ``` Collecting data for '/dev/sda'... Saving to sat-Intel_S4510_S4610_S4500_S4600_Series_SSDs-INTEL_SSDSC2KB240G8-sda.json Collecting data for '/dev/sdb'... Saving to sat-Intel_S4510_S4610_S4500_S4600_Series_SSDs-INTEL_SSDSC2KB240G8-sdb.json Collecting data for '/dev/bus/0'...jq: error (at <stdin>:34): null (null) cannot be matched, as it is not a string Saving to null-null--0.json Collecting data for '/dev/bus/0'...jq: error (at <stdin>:34): null (null) cannot be matched, as it is not a string Saving to null-null--0.json Collecting data for '/dev/nvme0'... Saving to nvme-null-HUSMR7632BHP301-nvme0.json Collecting data for '/dev/nvme1'... Saving to nvme-null-HUSMR7632BHP301-nvme1.json Collecting data for '/dev/nvme2'... Saving to nvme-null-HUSMR7632BHP301-nvme2.json Collecting data for '/dev/nvme3'... Saving to nvme-null-HUSMR7632BHP301-nvme3.json Collecting data for '/dev/nvme4'... Saving to nvme-null-HUSMR7632BHP301-nvme4.json ``` The `/dev/bus/*` is some pseudo-device comes with Broadcom driver, after fix: ``` Collecting data for '/dev/sda'... Saving to sat-Intel_S4510_S4610_S4500_S4600_Series_SSDs-INTEL_SSDSC2KB240G8-sda.json Collecting data for '/dev/sdb'... Saving to sat-Intel_S4510_S4610_S4500_S4600_Series_SSDs-INTEL_SSDSC2KB240G8-sdb.json Collecting data for '/dev/nvme0'... Saving to nvme-null-HUSMR7632BHP301-nvme0.json Collecting data for '/dev/nvme1'... Saving to nvme-null-HUSMR7632BHP301-nvme1.json Collecting data for '/dev/nvme2'... Saving to nvme-null-HUSMR7632BHP301-nvme2.json Collecting data for '/dev/nvme3'... Saving to nvme-null-HUSMR7632BHP301-nvme3.json Collecting data for '/dev/nvme4'... Saving to nvme-null-HUSMR7632BHP301-nvme4.json ``` Signed-off-by: Konstantin Shalygin <[email protected]>
This isn't a redaction bug. This is Toshiba. I think the SMART table have some limitations, and vendor reduced number of symbols this way
From 12/24/36 devices in chassis - on your choose |
robbat2
approved these changes
Dec 30, 2023
Signed-off-by: Konstantin Shalygin <[email protected]>
|
Rebased: removed |
robbat2
approved these changes
Jan 3, 2024
|
@k0ste I'll have a look this weekend. Thanks! |
NiceGuyIT
added a commit
that referenced
this pull request
May 5, 2024
collect-smartctl-json: shell fixes for script (#188)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more testdata. Produced & redacted via scripts
Current prometheus query to ignore (this models testdata present)