Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chg: Impvoe the JSON collection script; now requires jq/yq #176

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Chg: Impvoe the JSON collection script; now requires jq/yq #176

merged 1 commit into from
Nov 17, 2023

Conversation

NiceGuyIT
Copy link
Member

  • Don't use sudo if root
  • Check if sudo exists
  • Add family and model name to the filename. Sometimes family/model is "null"
  • Requires yq or jq to extract the family/model from the filename

@NiceGuyIT NiceGuyIT merged commit 6acadc6 into prometheus-community:master Nov 17, 2023
5 checks passed
SuperQ added a commit that referenced this pull request Mar 3, 2024
@SuperQ
Release v0.12.0
a60837f 
* [CHANGE] Better SCSI/SAS support, and removing confused metrics #168
* [ENHANCEMENT] Impvoe the JSON collection script; now requires jq/yq #176
* [BUGFIX] Shell fixes for `collect-smartctl-json.sh` #178
* [BUGFIX] Various fixes to `collect_fake_json.sh` #159

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ mentioned this pull request Mar 3, 2024
Merged
@chennin chennin mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbat2 robbat2 robbat2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiceGuyIT @robbat2