-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kube-prometheus-stack] add tpl to some templates #4901
base: main
Are you sure you want to change the base?
[kube-prometheus-stack] add tpl to some templates #4901
Conversation
Your change is already covered by
That should solve your case? |
5e35658
to
3414aaf
Compare
Thanks @jkroepke for the quick response ! Correct, that solved the issue I had with I updated my PR accordingly. |
c83eb8f
to
a3d6c7a
Compare
Signed-off-by: Dennis Zheleznyak <[email protected]>
a3d6c7a
to
d5cfd14
Compare
Hi @jkroepke :) can this be merged please ? |
@@ -217,14 +217,14 @@ spec: | |||
{{- end }} | |||
{{- with .Values.prometheusOperator.nodeSelector }} | |||
nodeSelector: | |||
{{ toYaml . | indent 8 }} | |||
{{ tpl (toYaml .) $ | indent 8 }} | |||
{{- end }} | |||
{{- with .Values.prometheusOperator.affinity }} | |||
affinity: | |||
{{ toYaml . | indent 8 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add tpl here as well? addinity are in the same line as nodeselector and tolerations
What this PR does / why we need it
We're moving our infra charts from Terraform to ArgoCD/ApplicationSets and we need the ability to template nodeSelector and tolerations
[prometheus-couchdb-exporter]
)