Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-snmp-exporter] Extend workload config #4488

Merged
merged 2 commits into from
Apr 26, 2024
Merged

[prometheus-snmp-exporter] Extend workload config #4488

merged 2 commits into from
Apr 26, 2024

Conversation

ngc4579
Copy link
Contributor

@ngc4579 ngc4579 commented Apr 25, 2024

  • Introduce optional revisionHistoryLimit for Deployment / DaemonSet

@Miouge1 @xiu @walker-tom

What this PR does / why we need it

Make the Deployment / DaemonSet revisionHistoryLimit configurable by introducing an optional Parameter to values.yaml.

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

- Introduce optional revisionHistoryLimit for Deployment / DaemonSet

Signed-off-by: ngc4579 <[email protected]>
Copy link
Contributor

@walker-tom walker-tom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

charts/prometheus-snmp-exporter/Chart.yaml Outdated Show resolved Hide resolved
@walker-tom walker-tom merged commit 9c41858 into prometheus-community:main Apr 26, 2024
4 checks passed
wilfriedroset pushed a commit to wilfriedroset/helm-charts that referenced this pull request May 8, 2024
…ty#4488)

* [prometheus-snmp-exporter] Extend workload config

- Introduce optional revisionHistoryLimit for Deployment / DaemonSet

Signed-off-by: ngc4579 <[email protected]>

* Update charts/prometheus-snmp-exporter/Chart.yaml

Signed-off-by: Tom Walker <[email protected]>

---------

Signed-off-by: ngc4579 <[email protected]>
Signed-off-by: Tom Walker <[email protected]>
Co-authored-by: Tom Walker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants