[prometheus-modbus-exporter] fix deployment template #4436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Hi, I have discover that the current deployment template for the
prometheus-modbus-exporter
does not handle the overloading of the registry that can be found in the values.In the values.yaml there is two references for that action:
But the actions in the deployment template are:
The proposed change includes the .values.image.registry in the image address.
This PR is to fix that and allow the user to use a different registry for the main image and the sidecar.
The chart has also been bumped from
0.1.0
to0.1.1
to reflect the changes.Which issue this PR fixes:
Checklist: