[alertmanager] Add securityContext to configmap reload #3659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlindner
force-pushed
the
feature/Add_Security_context_to_config_reload
branch
2 times, most recently
from
752ff67
to
948783a
Compare
monotek
requested changes
Aug 7, 2023
robertlindner
force-pushed
the
feature/Add_Security_context_to_config_reload
branch
from
fd54d6f
to
e50315f
Compare
Signed-off-by: Robert Lindner <[email protected]>
Signed-off-by: Robert Lindner <[email protected]>
robertlindner
force-pushed
the
feature/Add_Security_context_to_config_reload
branch
from
e50315f
to
4fec72a
Compare
monotek
approved these changes
Aug 8, 2023
monotek
requested changes
Aug 8, 2023
There was a problem hiding this comment.
please sign your commits to get dco check work: https://github.com/prometheus-community/helm-charts/pull/3659/checks?check_run_id=15703277048
to be consistent with the previous behavior Signed-off-by: Robert Lindner <[email protected]>
robertlindner
force-pushed
the
feature/Add_Security_context_to_config_reload
branch
from
4fec72a
to
baa96f7
Compare
monotek
approved these changes
Aug 14, 2023
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Aug 25, 2023
…mmunity#3659) * Add securityContext to configmap reload Signed-off-by: Robert Lindner <[email protected]> * Configure configmapReload securityContext via seperate values Signed-off-by: Robert Lindner <[email protected]> * Default the securityContext for configmapReload to empty object to be consistent with the previous behavior Signed-off-by: Robert Lindner <[email protected]> --------- Signed-off-by: Robert Lindner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
When adding the sidecar container via helm values, our policies complain about the container not having security context set.
This sets the
securityContextof the configmap reloader to the same values as the main container, to prevent it from running as root.Which issue this PR fixes
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])