-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin all python dependencies #283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it still work fine with the pinned pandas dependency?
I could be wrong, but IIRC there were some issues with pandas before - but could be no longer an issue since we dropped support for Google Colab.
define "it" 😅 as you can see the tests are passing... |
Ah - should have been more precise... "it" == mybinder |
ok i re-tested everything i built the new image tag locally:
then locally modified the Dockerfile to use the local image:
and then ran the repo2docker logic:
and i was able to execute all 4 notebooks without errors. |
I meant to run the notebooks in binder from your branch. |
how do you think its different than running also pretty sure testing on binder would run into #272 still |
actually i dont think you can test this branch on binder because the base image tag has changed and is not available yet in the github repo: it is only published once the workflow on |
Doesn't it work via e.g. https://mybinder.org/v2/gh/XN137/nessie-demos/pin-all-python-reqs?filepath=notebooks/nessie-iceberg-demo-nba.ipynb ? |
the link runs into the problem of not finding the base image (since as i mentioned, it is not published to ghcr.io yet).
|
after workflows ran on main i confirmed the binder notebooks still work, so everything went fine i think. |
Split out from #280
we should pin all dependencies to avoid random new version releases form affecting our build.
however in the
pandas
case we relied on pip selecting the right version for us, which needs to be compatible with the (strange) flink dependencies, thus we are now pinning different versions in the respective requirement files.also noticed that
flake8
was in thedev
requirements, while its plugins where in thelint
requirements, which does not make much sense.Since we are now using the more restrictive pip dependency resolver (see #280) we should clean up this inconsistency to avoid incompatibilities going forward.